Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pdf): replace mr-pdf with maintained fork docs-to-pdf #9212

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

jean-humann
Copy link
Contributor

@jean-humann jean-humann commented Aug 8, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This PR is to replace mr-pdf which is not maintained anymore for than a year by a fork up to date with the last dependencies & security fix and enriched with new features.
docs-to-pdf Allow (as did mr-pdf) the users to generate PDF form docusaurus v1 or v2.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @jean-humann!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Aug 8, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 031cc82
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64d286182bb661000843932e
😎 Deploy Preview https://deploy-preview-9212--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 88 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 78 🟢 100 🟢 92 🟢 100 🟠 89 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 8, 2023
@jean-humann
Copy link
Contributor Author

The issue where the owner of old repo acknowledge the handover : kohheepeace/mr-pdf#70

@slorber
Copy link
Collaborator

slorber commented Aug 10, 2023

LGTM thanks 👍

@slorber slorber merged commit fa39e8c into facebook:main Aug 10, 2023
7 of 8 checks passed
@jean-humann jean-humann deleted the docs/replace_mr_pdf branch August 12, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants