Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BuildProgressPlugin #950

Closed
wants to merge 2 commits into from
Closed

Add BuildProgressPlugin #950

wants to merge 2 commits into from

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 24, 2016

I figured I'd take a stab at #935 since it seemed relatively easy.

I do have a concern though!
I created the plugin in react-dev-utils per suggestion in #935, however this resulted in adding webpack as a dependency 😱 -- it was listed as a peerDependency previously (which fails to resolve post lerna/lerna#318).
Would it be better to implement it in react-scripts and add progress as a dependency? Or would you rather explore a solution which doesn't use progress?

edit: read below

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor Author

Timer commented Oct 24, 2016

Using the same technique used in https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/paths.js#L74, I changed webpack back to a peerDependency in ee9ca5e.

@Timer
Copy link
Contributor Author

Timer commented Nov 4, 2016

Closing this as the solution doesn't seem appropriate given the webpack peerDependency was removed in #963 / 9d53d22.
It seems the solution for this will be implemented elsehow (not in react-dev-utils, but perhaps in react-scripts).

@Timer Timer closed this Nov 4, 2016
@gaearon
Copy link
Contributor

gaearon commented Nov 4, 2016

Sorry, I had no time to look at this yet. I will, can you please reopen?

require('webpack').ProgressPlugin should be fine. Peer dependency was only removed because now that we declare compat with Webpack 2, it will be annoying to bump it every few weeks. If npm provided a way to declare compat with all beta versions, I would've kept it.

But we are assuming specific plugins in react-dev-utils rely on Webpack. It's fine to import anything from it if these things are supported in 1.x and 2.x.

@Timer Timer mentioned this pull request Nov 5, 2016
@Timer
Copy link
Contributor Author

Timer commented Nov 5, 2016

@gaearon Sure, unfortunately github won't let me reopen this pull request as I rebased before reopening it -- oops! I've created a new one (#1011) and added associated discussion to it.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants