Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the Workbox InjectManifest plugin #9205

Merged
merged 26 commits into from
Jul 22, 2020
Merged

Switch to the Workbox InjectManifest plugin #9205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
54d3740
WIP
jeffposnick Jun 11, 2020
e9fa48b
WIP
jeffposnick Jun 11, 2020
5a3a6c7
Rename
jeffposnick Jun 11, 2020
0eed437
Use publicPath
jeffposnick Jun 11, 2020
3308fb6
Getting closer.
jeffposnick Jun 11, 2020
b0cab1b
Move off of NavigationRoute
jeffposnick Jun 23, 2020
53b142a
Update the PWA guide
jeffposnick Jun 23, 2020
8707cc7
Don't precache any LICENSEs.
jeffposnick Jun 23, 2020
d2545aa
Updated the ignore instructions
jeffposnick Jun 23, 2020
3ee8b1f
skipWaiting message handler
jeffposnick Jun 23, 2020
a893129
Added a comment
jeffposnick Jun 23, 2020
8ff1fe3
Merge branch 'master' into wb-inject-manifest
ianschmitz Jun 26, 2020
f96d1d2
Add back web vitals to typescript template
ianschmitz Jun 26, 2020
c674f01
Add web vitals back to javascript template
ianschmitz Jun 26, 2020
d22c7dc
Change references of CRA 3 to 4
ianschmitz Jun 26, 2020
563589c
Add webworker lib ref
ianschmitz Jun 26, 2020
49b27d5
Fix TypeScript errors in service-worker.ts
ianschmitz Jun 26, 2020
f8245c9
Add back eslint disable comment
ianschmitz Jun 26, 2020
f3adc73
Ignore restricted-globals across entire file
ianschmitz Jun 26, 2020
94d6494
Runtime caching
jeffposnick Jun 26, 2020
d949faa
Explicitly depend on Workbox libs
jeffposnick Jun 29, 2020
b02ebb4
Remove SW and package.json deps
jeffposnick Jul 13, 2020
7f768c9
WIP update to README.
jeffposnick Jul 13, 2020
34a46dc
Updates to the docs.
jeffposnick Jul 13, 2020
419a883
Explicitly require InjectManifest
jeffposnick Jul 13, 2020
991e683
Switch back.
jeffposnick Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename
  • Loading branch information
@jeffposnick
jeffposnick committed Jun 11, 2020
commit 5a3a6c72c9652234ee9bc99ff9504f1f44c21aed
0 ...ra-template-typescript/template/src/sw.ts → ...typescript/template/src/service-worker.ts
View file
Open in desktop
File renamed without changes.
0 packages/cra-template/template/src/sw.js → ...a-template/template/src/service-worker.js
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions packages/react-scripts/config/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ module.exports = {
proxySetup: resolveApp('src/setupProxy.js'),
appNodeModules: resolveApp('node_modules'),
publicUrlOrPath,
swSrc: resolveApp('src/sw'),
swSrc: resolveApp('src/service-worker'),
};

// @remove-on-eject-begin
Expand Down Expand Up @@ -101,7 +101,7 @@ module.exports = {
ownNodeModules: resolveOwn('node_modules'), // This is empty on npm 3
appTypeDeclarations: resolveApp('src/react-app-env.d.ts'),
ownTypeDeclarations: resolveOwn('lib/react-app.d.ts'),
swSrc: resolveApp('src/sw'),
swSrc: resolveApp('src/service-worker'),
};

const ownPackageJson = require('../package.json');
Expand Down Expand Up @@ -137,7 +137,7 @@ if (
ownNodeModules: resolveOwn('node_modules'),
appTypeDeclarations: resolveOwn(`${templatePath}/src/react-app-env.d.ts`),
ownTypeDeclarations: resolveOwn('lib/react-app.d.ts'),
swSrc: resolveApp('src/sw'),
swSrc: resolveApp('src/service-worker'),
};
}
// @remove-on-eject-end
Expand Down