Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resetMocks to true by default in jest config #7899

Merged
merged 1 commit into from
May 4, 2020

Conversation

alexkrolick
Copy link
Contributor

@alexkrolick alexkrolick commented Oct 29, 2019

See also jestjs/jest#9047

@alexkrolick
Copy link
Contributor Author

I think this would be a breaking change

@kentcdodds
Copy link
Contributor

I agree with this PR. But I wouldn't hold up #7881 for this. You can definitely use React Testing Library without this enabled.

@ianschmitz
Copy link
Contributor

Agreed. I have always set this to true in my jest config of my CRA apps after creation. Populating the jest config in the package.json by default in our bootstrapped apps could accomplish this as a non-breaking change.

I'm for it, let's see what the other maintainers think.

@ianschmitz ianschmitz added this to the 3.x milestone Oct 29, 2019
@ianschmitz ianschmitz modified the milestones: 3.x, 4.0 Jan 31, 2020
@ianschmitz ianschmitz closed this May 4, 2020
@ianschmitz ianschmitz reopened this May 4, 2020
@alexkrolick
Copy link
Contributor Author

I'm still all for this change

@ianschmitz ianschmitz merged commit 4974a20 into facebook:master May 4, 2020
@alexkrolick alexkrolick deleted the patch-2 branch May 4, 2020 03:25
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants