Extract some utilities into a separate package #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Need to add |
|
Ok, eject in the e2e test still tries to install our packages from |
vjeux
reviewed
Sep 23, 2016
| var prompt = require('react-dev-utils/prompt'); | ||
| prompt( | ||
| 'Are you sure you want to eat all the candy?', | ||
| false |
There was a problem hiding this comment.
I always put a comment for boolean variables with what they mean, otherwise it's pretty confusing :)
/* isYesDefault*/ falseThere was a problem hiding this comment.
Even better:
prompt('Are you sure you want to eat all the candy?', { default: false });
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Extract some utilities into a separate package * Add utils dir to `files` in package.json * Do not create an empty `utils` dir on eject
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes projects cleaner after ejecting!