Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a shareable ESLint configuration package #689

Merged
merged 13 commits into from
Sep 21, 2016
Merged

Create a shareable ESLint configuration package #689

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a4b4fe3
Move ESLint configuration to a separate package
fson Sep 20, 2016
603cff0
Remove the ESLint configuration, moved to eslint-config-react-app
fson Sep 20, 2016
2d2e7af
Update ESLint instructions
fson Sep 20, 2016
5c9f7ac
Pin the package versions in eslint-config-react-app
fson Sep 20, 2016
8dbfe66
Add a README for eslint-config-react-app
fson Sep 20, 2016
7e55f86
Update README.md
fson Sep 21, 2016
e2dc36e
Update README.md
fson Sep 21, 2016
cfa6880
Update README.md
fson Sep 21, 2016
f2665d8
Update README.md
gaearon Sep 21, 2016
2db2ebe
Update package.json
gaearon Sep 21, 2016
0881de1
Update package.json
gaearon Sep 21, 2016
5c4458c
Update production eslint-loader config
fson Sep 21, 2016
996bf67
Add the ESLint config to devDependencies of the repo
fson Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ESLint instructions
  • Loading branch information
@fson
fson committed Sep 20, 2016
commit 2d2e7af70c5a47d41604153e57efeef009b403c2
4 changes: 2 additions & 2 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,15 +163,15 @@ Then add this block to the `package.json` file of your project:
{
// ...
"eslintConfig": {
"extends": "./node_modules/react-scripts/config/eslint.js"
"extends": "react-app"
}
}
```

Finally, you will need to install some packages *globally*:

```sh
npm install -g eslint babel-eslint eslint-plugin-react eslint-plugin-import eslint-plugin-jsx-a11y eslint-plugin-flowtype
npm install -g eslint-config-react-app eslint babel-eslint eslint-plugin-react eslint-plugin-import eslint-plugin-jsx-a11y eslint-plugin-flowtype
```

We recognize that this is suboptimal, but it is currently required due to the way we hide the ESLint dependency. The ESLint team is already [working on a solution to this](https://github.com/eslint/eslint/issues/3458) so this may become unnecessary in a couple of months.
Expand Down