Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on enabling Travis CI for created repo #677

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

Jiansen
Copy link
Contributor

@Jiansen Jiansen commented Sep 18, 2016

As promised in #365 , adding notes on enabling Travis CI for a generated app.

Demo

Effects of Change

In the generated app, users will see the note under the Continuous Integration section.

Local verification

In a development branch, run npm run create-react-app my-app and check the README.md in the generated app (my-app).

Note

Build 3 encounters the following error on the Node 4 test. As the Node 6 build succeeds, the failure shall not be related to CRA.

> [email protected] test /home/travis/build/Jiansen/CRA-Travis-Demo
> react-scripts test --env=jsdom
module.js:327
    throw err;
    ^
Error: Cannot find module 'lru-cache'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/travis/build/Jiansen/CRA-Travis-Demo/node_modules/react-scripts/node_modules/cross-spawn/lib/parse.js:4:11)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
npm ERR! Test failed.  See above for more details.

@ghost ghost added the CLA Signed label Sep 18, 2016
@Jiansen
Copy link
Contributor Author

Jiansen commented Sep 19, 2016

Update:

The same issue is reported in #676 and is fixed with 0.4.3.

No change is required to the proposed .travis.yml file.

directories:
- node_modules
script
- CI=true npm test
Copy link
Contributor

@ayrton ayrton Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually not necessary as travis will add this by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayrton , I removed CI=true in updated commit. Also I added back node 4 tests as the issue is fixed in the new version

@Jiansen Jiansen force-pushed the doc-set-travis-in-generated-app branch from 18d6d2b to 684c903 Compare September 20, 2016 22:18
@ghost ghost added the CLA Signed label Sep 20, 2016
@Jiansen Jiansen force-pushed the doc-set-travis-in-generated-app branch from 684c903 to 4d16d1c Compare September 20, 2016 22:23
@gaearon gaearon merged commit 4e8c5e0 into facebook:master Sep 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Thanks!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants