Improve the output of scripts/init.js #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| console.log(); | ||
| console.log(chalk.cyan('npm run eject')); | ||
| console.log(' Removes this tool and copies build dependencies, configs,') | ||
| console.log(' and scripts into the app directory.') |
There was a problem hiding this comment.
Looks like this line and the one above it are missing semicolons in the end, can you add them back? Otherwise everything seems to be in order now 👌
|
Fixed 😄 |
|
Great, thanks for pulling it through! 👍 |
| console.log(' Bundles the app into static files for production.'); | ||
| console.log(); | ||
| console.log(chalk.cyan('npm run eject')); | ||
| console.log(' Removes this tool and copies build dependencies, configs,'); |
There was a problem hiding this comment.
@fson Can you please change "configs" to "configuration files" directly in master? I'd like to avoid jargon in messages.
Merged
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Improve the output of scripts/init.js * Add semi-colons;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fson Ran into major problems with git trying to merge this pull-request:
#363