Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pushing .pnp folder to git #5469

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Conversation

NShahri
Copy link
Contributor

@NShahri NShahri commented Oct 18, 2018

The same as node_modules, .pnp folder should be ignored by git

NOTE:
Not sure about .pnp.js

Avoid pushing .pnp folder to git
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Oct 18, 2018

@arcanis ?

@NShahri
Copy link
Contributor Author

NShahri commented Oct 18, 2018

as .pnp.js will be generated/updated by yarn install or yarn add, also should be ignored by git. Let me know if I am right to update the template file.

@arcanis
Copy link
Contributor

arcanis commented Oct 18, 2018

Yup, sounds good 👍

We'll eventually want to allow them to be checked-in along with the offline cache (install-less Yarn), but at the moment it's better to ignore both of them 🙂

@NShahri
Copy link
Contributor Author

NShahri commented Oct 23, 2018

@gaearon What do you think about it, also I do not have any idea how to rerun AppVeyor or fix the Build execution time has reached the maximum allowed time for your plan (60 minutes) error.

@Timer Timer added this to the 2.1 milestone Oct 23, 2018
@Timer
Copy link
Contributor

Timer commented Oct 23, 2018

No worries about the CI error, @NShahri. Thanks for this!

@Timer Timer merged commit 787a4a7 into facebook:master Oct 23, 2018
chanand pushed a commit to chanand/create-react-app that referenced this pull request Oct 25, 2018
* Add .pnp folder ro gitignore file

Avoid pushing .pnp folder to git

* Add .pnp.js to ignore list
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
* Add .pnp folder ro gitignore file

Avoid pushing .pnp folder to git

* Add .pnp.js to ignore list
nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
* Add .pnp folder ro gitignore file

Avoid pushing .pnp folder to git

* Add .pnp.js to ignore list
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants