Update Jest #530
Merged
Update Jest #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
lgtm, the test file is very simple, I like it :) |
| test -e src/__tests__/__snapshots__/App-test.js.snap | ||
| npm test -- --smoke-test | ||
| # Uncomment when snapshot testing is enabled by default: | ||
| # test -e src/__tests__/__snapshots__/App-test.js.snap |
There was a problem hiding this comment.
do you mean App.spec.js here?
There was a problem hiding this comment.
Since it's disabled this doesn't really matter—when we re-add it we can revisit naming and where we put it.
|
boom. |
Merged
stayradiated
pushed a commit
to stayradiated/create-react-app
that referenced
this pull request
Sep 7, 2016
* Update Jest * Remove default snapshot test * Fix a few things * Add a simple default test * App.spec.js -> App.test.js * Fix e2e test * Bump Jest
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Update Jest * Remove default snapshot test * Fix a few things * Add a simple default test * App.spec.js -> App.test.js * Fix e2e test * Bump Jest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs another fix scheduled for 15.0.1 but should be almost good to go.