Add a hash to media files even in the devmode. #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will work correctly when there are duplicate filenames in different paths. Fixes: facebook#445
ghost
added
the
|
I tried the fix by ejecting the app and it worked pretty well. Do you know how can I write tests for this? |
|
Thanks. |
gaearon
pushed a commit
that referenced
this pull request
Aug 22, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: #445
Merged
stayradiated
pushed a commit
to stayradiated/create-react-app
that referenced
this pull request
Sep 7, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: facebook#445
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: facebook#445
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will work correctly when there are duplicate filenames in different paths.
Fixes: #445