Tell user what browser support their application was built with #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jan 14, 2018
| return { | ||
| error: false, | ||
| message: chalk.yellow( | ||
| '$BROWSERSLIST was specified in your environment. ' + |
There was a problem hiding this comment.
I'm not feeling great about being patronizing here.
If we decided to use browserlist then IMO we should embrace however they're doing it. I think our tone should be more like
"Built the bundle with support for (list of browsers) because (where we read the list)"
There was a problem hiding this comment.
Do we care about where the configuration comes from, or just to display what configuration was used?
There was a problem hiding this comment.
It would be nice to display both. But if that requires reimplementing half of browserlist maybe we can just show the config used, and file an issue with them asking to expose the source info.
7dd25b6
to
e7a7a6f
Compare
|
This is good enough for an alpha. |
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* Warn about browsers during build * Better message
Timer
added a commit
to Timer/create-react-app
that referenced
this pull request
Jan 15, 2018
…book#3782) * Warn about browsers during build * Better message
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
…book#3782) * Warn about browsers during build * Better message
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
…book#3782) * Warn about browsers during build * Better message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR warns about specifying browsers with a method other than
package.jsonafter build.This PR also prevents
build/startwhen no browsers are specified.TODO:
package.json(?)Fixes #3779