Force rebuild after npm install #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| var nodeModulesPath = this.nodeModulesPath; | ||
|
|
||
| // If any missing files are expected to appear in node_modules... | ||
| if (missingDeps.some(file => file.indexOf(nodeModulesPath) !== -1)) { |
There was a problem hiding this comment.
Does the minimum node version we support have arrow functions support?
| compilation.contextDependencies.push(nodeModulesPath); | ||
| } | ||
|
|
||
| callback(); |
There was a problem hiding this comment.
Express middleware calls this next, which I think is more explicit than callback
There was a problem hiding this comment.
Most webpack plugins I saw use callback here but I don’t care either way, feel free to change.
There was a problem hiding this comment.
Just trying to give more context, I don't particularly care :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186