Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off .babelrc usage (fixes #233) #236

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Conversation

alexzherdev
Copy link
Contributor

Here is how I verified.

  1. cloned create-react-app
  2. created .babelrc in the parent directory as specified in "npm start" error if there is a .babelrc file in parent folder #233
  3. ran npm start in create-react-app and got the error message

With the fix in place, I'm no longer getting the "Failed to compile" message.

@ghost ghost added the CLA Signed label Jul 27, 2016
@mxstbr
Copy link
Contributor

mxstbr commented Jul 27, 2016

Awesome, thanks so much @alexzherdev!

@mxstbr
Copy link
Contributor

mxstbr commented Jul 27, 2016

Awesome, thanks so much @alexzherdev! 🎉

@gaearon
Copy link
Contributor

gaearon commented Jul 27, 2016

Let’s wait for e2e next time for things that touch configs 😉

@alexzherdev
Copy link
Contributor Author

@gaearon do you mean the end-to-end flow mentioned in CONTRIBUTING.md?
I just did it and created a project with npm run create-react-app. It worked fine but thanks for making me aware of this.

@gaearon
Copy link
Contributor

gaearon commented Jul 27, 2016

@alexzherdev No, I meant waiting for Travis test before merging, this was a comment to @mxstbr. Sometimes Travis catches stuff that manual end to end flow might not catch.

@mxstbr
Copy link
Contributor

mxstbr commented Jul 27, 2016

@gaearon I swear Travis was green, I actually looked at the log and waited for it to finish…

@gaearon
Copy link
Contributor

gaearon commented Jul 27, 2016

Haha, okay then, sorry! Maybe it restarts when I merge something else to master? Don't worry then.

@mxstbr
Copy link
Contributor

mxstbr commented Jul 27, 2016

screen shot 2016-07-27 at 17 02 08

@gaearon gaearon added this to the 0.2.0 milestone Jul 27, 2016
@gaearon gaearon mentioned this pull request Jul 27, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants