Add select eslint-plugin-jsx-a11y rules to lint config. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project is a really good use case to apply some accessibility rules to the lint config. For beginners getting started with React, we can also teach/enforce basic accessibility rules in the web at author time. For now, I’ve just applied to the rules that are listed in `eslint-config-airbnb` because these are most real-world tested, and we can continue to add. Happy to help if there are any questions/issues/concerns about the plugin!
ghost
added
the
|
Another constraint is we don’t want to overwhelm developers with lint warnings, or they’ll just start ignoring them. These rules appear sensible to me and I’d be up to merge this. I’d like a 👍 from @lacker on this. |
|
This looks very solid to me, great addition! |
|
This looks good to me. I can't think of any reason offhand for images to not have an alt, although honestly I know I skip alts a lot, so let's merge it and see. |
|
Great, thanks! FYI - don't need alt when <img src="foo" alt="" />
<img src="foo" role="presentation" /> |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is a really good use case to apply some accessibility rules to the lint config. For beginners getting started with React and/or web in general, we can also teach & enforce basic accessibility rules in the web at author time.
For now, I’ve just applied to the rules that are listed in
eslint-config-airbnbbecause these are most real-world tested, and we can continue to add as you see fit.I know from Twitter that you're wary about adding more dependencies, but very happy to help if there are any questions/issues/concerns about the plugin!