Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel-eslint version #1214

Merged
merged 1 commit into from
Dec 11, 2016
Merged

Conversation

existentialism
Copy link
Contributor

Codeframin':

image

Fixes #1206

@tbillington
Copy link

tbillington commented Dec 9, 2016

Just curious, what is that, Lightsaber operator? It's impossible to google because google doesn't respect quote marks anymore.

Ah I understand what you're doing now. I thought there was new javascript syntax....

@gaearon
Copy link
Contributor

gaearon commented Dec 11, 2016

In this case the screenshot in server mode doesn't tell the whole story because we hide ESLint messages on syntax errors.

However I checked that if we remove these lines, it now appears.

For now I'll keep hiding them to prevent duplicate errors but this might be useful in future because it lets us call ESLint separately and still get nice messages.

Thanks!

@gaearon gaearon merged commit 801b955 into facebook:master Dec 11, 2016
@gaearon gaearon added this to the 0.8.4 milestone Dec 11, 2016
@gaearon gaearon mentioned this pull request Dec 11, 2016
@existentialism existentialism deleted the issue1206 branch December 11, 2016 14:27
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants