Catch synchronous errors from spawning yarn #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fson
reviewed
Dec 8, 2016
| if (yarnExists) { | ||
| callback(code, 'yarn', yarnArgs); | ||
| return; | ||
| } |
There was a problem hiding this comment.
You need to call fallbackToNpm() here, so that we'll fall back to npm if the yarn process emitted the ENOENT error, which is asynchronous (handled above).
| var yarnProc; | ||
| var yarnExists = true; | ||
| try { | ||
| yarnProc = spawn('yarn', yarnArgs, {stdio: 'inherit'}); |
There was a problem hiding this comment.
I'd only wrap this single line with try-catch, because that's the thing we need to catch the errors from. I don't want us to get stuck in an infinite loop if something else fails in the fallback npm command for example.
|
Looks good to me 👍 |
Merged
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
* Catch synchronous errors from spawning yarn * Fix issues
randycoulman
pushed a commit
to CodingZeal/create-react-app
that referenced
this pull request
May 8, 2017
* Catch synchronous errors from spawning yarn * Fix issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes #1200.
Apparently
spawnsometimes fails synchronously and sometimes fails in an event emitter.I restructured the code a tiny bit.