Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30846: Dropped deprecated Symfony\Component\Config\Definition\Bui… #7

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Aug 9, 2019

…lder\TreeBuilder::root method calls

Question Answer
JIRA issue EZP-30846
Bug/Improvement yes
New feature no
Target version master
BC breaks no
Tests pass yes
Doc needed no

Since Symfony 4.3 configuration root name should be passed via constructor instead of using "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method.

More information:

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs added the Improvement Improvement (not a bug) for existing feature label Aug 9, 2019
@adamwojs adamwojs self-assigned this Aug 9, 2019
@micszo micszo added the QA approved QA tests were successful label Aug 12, 2019
@lserwatka lserwatka merged commit 70b2def into master Aug 12, 2019
@lserwatka lserwatka deleted the ezp_30846 branch August 12, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement (not a bug) for existing feature QA approved QA tests were successful
Development

Successfully merging this pull request may close these issues.

4 participants