Fix wrong namespaces #33
Conversation
|
Ping @andrerom @crevillo @bdunogier |
| @@ -11,7 +11,6 @@ | |||
| use EzSystems\EzPriceBundle\SPI\Persistence\Price\VatHandler as VatHandlerInterface; | |||
| use EzSystems\EzPriceBundle\Core\Persistence\Legacy\Price\Vat\Gateway; | |||
| use EzSystems\EzPriceBundle\API\Price\Values\VatRate; | |||
| use EzSystems\EzPriceBundle\Core\Persistence\Legacy\Price\Vat\AutomaticVatHandlerException; | |||
There was a problem hiding this comment.
while one this, could you please port this change to https://github.com/blankse/EzPriceBundle/blob/fix_wrong_namespaces/Core/Persistence/Legacy/Price/Vat/VatHandler.php#L35?
There was a problem hiding this comment.
How do you mean?
So?
@throws AutomaticVatHandlerException when automatic VAT is used.
Should we everywhere avoid the namespaces in PHPDocs when it is integrated per use command?
There was a problem hiding this comment.
ah, sorry. it's ok. thought namespace in param was wrong but it wasn't about avoiding namespaces really don't know. sometimes i see params with namespaces and sometimes not. Don't worry about my comment.
There was a problem hiding this comment.
OK :)
Yes, here the namespace was not wrong. Only unnecessary ;)
There was a problem hiding this comment.
my phpstorm was saying it was wrong but only because i haven't added the change you made in the other file. Thanks @blankse
|
apart from that remark, +1 to me. |
|
Let's merge this as is phpdoc and namespacing related and seems ok to me. Thanks @blankse |
No description provided.