fix: convert empty space to %20 when render hyperlinks
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cafkafk Do you know who else could review this PR? Thanks |
Anyone in commiters could, but reviews are volunteering, so there's no strict timeframe. Sadly none of us are currently paid to do this fulltime, but as soon as someone is available I'm sure they'll review it. I usually do some batch reviews a few times a month, where I might look at this :) |
|
@cafkafk Do you have time to check it now? it's a small change. |
|
ping |
PThorpe92
previously approved these changes
Sep 7, 2024
|
@PThorpe92 ping, i have resolve the conflicts. |
PThorpe92
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #843
https://docs.rs/percent-encoding/latest/percent_encoding/fn.utf8_percent_encode.html