feat(utils): add function filterEffects

exuanbo · Jul 29, 2023 · d7c162f · d7c162f
1 parent 7462c4d
commit d7c162f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/.yarn/versions/7bf34662.yml b/.yarn/versions/7bf34662.yml
@@ -0,0 +1,3 @@
+releases:
+ "@codemirror-toolkit/extensions": patch
+ "@codemirror-toolkit/utils": patch
diff --git a/packages/extensions/src/updateListener.ts b/packages/extensions/src/updateListener.ts
@@ -2,7 +2,7 @@ import type { Extension } from '@codemirror/state'
 import { StateEffect, StateField } from '@codemirror/state'
 import type { ViewUpdate } from '@codemirror/view'
 import { EditorView } from '@codemirror/view'
-import { isEffectOfType, mapEffectValue } from '@codemirror-toolkit/utils'
+import { filterEffects, mapEffectValue } from '@codemirror-toolkit/utils'
 
 export type UpdateListener = (update: ViewUpdate) => void
 
@@ -20,7 +20,7 @@ const updateListenerField = /*#__PURE__*/ StateField.define<UpdateListenerSet>({
  return new Set()
  },
  update(listeners, transaction) {
- transaction.effects.filter(isEffectOfType(UpdateListenerEffect)).forEach(
+ filterEffects(transaction.effects, UpdateListenerEffect).forEach(
  mapEffectValue((action) => {
  action.add?.forEach((listener) => listeners.add(listener))
  action.remove?.forEach((listener) => listeners.delete(listener))
@@ -29,13 +29,9 @@ const updateListenerField = /*#__PURE__*/ StateField.define<UpdateListenerSet>({
  return listeners
  },
  provide(thisField) {
- return EditorView.updateListener.from(
- thisField,
- (listeners) =>
- function aggregatedListener(update) {
- listeners.forEach((listener) => listener(update))
- },
- )
+ return EditorView.updateListener.from(thisField, (listeners) => (update) => {
+ listeners.forEach((listener) => listener(update))
+ })
  },
 })
 

diff --git a/packages/utils/src/state.ts b/packages/utils/src/state.ts
@@ -16,3 +16,10 @@ export function mapEffectValue<T, R>(
  ? (effect: StateEffect<T>) => arg1(effect.value)
  : arg2!(arg1.value)
 }
+
+export function filterEffects<T>(
+ effects: readonly StateEffect<unknown>[],
+ type: StateEffectType<T>,
+): StateEffect<T>[] {
+ return effects.filter(isEffectOfType(type))
+}