refactor(utils)!: rename isEffectOfType -> matchEffect

exuanbo · Dec 10, 2023 · 4e91959 · 4e91959
1 parent b50b367
commit 4e91959
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/.yarn/versions/89e28851.yml b/.yarn/versions/89e28851.yml
@@ -0,0 +1,3 @@
+releases:
+ "@codemirror-toolkit/extensions": patch
+ "@codemirror-toolkit/utils": minor
diff --git a/packages/utils/src/immutableSet.ts b/packages/utils/src/immutableSet.ts
@@ -12,17 +12,17 @@ export const ImmutableSetUtils = /*#__PURE__*/ Object.freeze({
  if (set.has(value)) {
  return set
  }
- const newSet = new Set(set)
- newSet.add(value)
- return newSet
+ const result = new Set(set)
+ result.add(value)
+ return result
  },
  delete: <T>(set: Set<T>, value: T): Set<T> => {
  if (!set.has(value)) {
  return set
  }
- const newSet = new Set(set)
- newSet.delete(value)
- return newSet
+ const result = new Set(set)
+ result.delete(value)
+ return result
  },
  clear: <T>(set: Set<T>): Set<T> => {
  if (!set.size) {

diff --git a/packages/utils/src/state.ts b/packages/utils/src/state.ts
@@ -1,6 +1,6 @@
 import type { StateEffect, StateEffectType } from '@codemirror/state'
 
-export function isEffectOfType<T>(type: StateEffectType<T>) {
+export function matchEffect<T>(type: StateEffectType<T>) {
  return (effect: StateEffect<unknown>): effect is StateEffect<T> => effect.is(type)
 }
 
@@ -21,5 +21,5 @@ export function filterEffects<T>(
  effects: readonly StateEffect<unknown>[],
  type: StateEffectType<T>,
 ): StateEffect<T>[] {
- return effects.filter(isEffectOfType(type))
+ return effects.filter(matchEffect(type))
 }