This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Pass in the Web Identity token to assumeRoleWithWebIdentity #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Flydiverny could I trouble you to review this when you get a mo? :) |
Flydiverny
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Following the discussion in #254 lets merge it, and we'll have a retake if someone finds opposing issues. Doesn't look like this should cause any extra trouble.
|
@dalgibbard thanks for taking your time with this :) |
|
Thanks a lot @Flydiverny ! Do you know when this is likely to make it into a release version? :) |
dalgibbard
added a commit
to dalgibbard/kubernetes-external-secrets
that referenced
this pull request
Jul 1, 2020
fix: pass in the Web Identity token to assumeRoleWithWebIdentity (external-secrets#417)
|
@dalgibbard I pinged @silasbw on slack asking for a release |
This was referenced Jul 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #254 - the recent changes don't appear to be working on EKS Fargate for me, and the AWS SDK documentation suggest you should provide the token into the
assumeRoleWithWebIdentitymethod params.Update: confirmed that the current master branch with WebIdentities results in an error because the web token is a required param: #254 (comment)
This change reads the token contents and passes them in.