This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Add last_state metric #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ee03ae
to
4744b96
Compare
It is a bit difficult to alert on sync_calls since they trigger into an error state and may stay there. This adds the gauge last_state. With last_state, people can easily alert on a value < 0 to indicate failure.
Flydiverny
approved these changes
Apr 22, 2020
karan-kap
pushed a commit
to aeristhings/kubernetes-external-secrets
that referenced
this pull request
Apr 25, 2020
It is a bit difficult to alert on sync_calls since they trigger into an error state and may stay there. This adds the gauge last_state. With last_state, people can easily alert on a value < 0 to indicate failure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit difficult to alert on sync_calls since they trigger into an error state and may stay there.
This adds the gauge last_state. With last_state, people can easily alert on a value < 0 to indicate failure.