This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
chore(release): separate chart and application release #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
reviewed
Oct 24, 2019
|
|
||
| ## Publishing a new chart release | ||
|
|
||
| If you're a maintainer use `./release-chart.sh <new-chart-version>` to start the release |
There was a problem hiding this comment.
How should someone get the new-chart-version to use?
There was a problem hiding this comment.
I am thinking we can get the new-chart-version by bumping the chart version here https://github.com/godaddy/kubernetes-external-secrets/blob/master/charts/kubernetes-external-secrets/Chart.yaml#L3 based on the changes. I can add this to the doc if this looks good to you.
silasbw
approved these changes
Oct 25, 2019
anarcher
pushed a commit
to anarcher/kubernetes-external-secrets
that referenced
this pull request
Oct 30, 2019
…ets#183) * chore(release): separate chart and application release
Flydiverny
pushed a commit
to Flydiverny/kubernetes-external-secrets
that referenced
this pull request
Nov 3, 2019
…ets#183) * chore(release): separate chart and application release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.