build: support Node.js 10.x

fixes #173
expressjs · Nov 20, 2018 · 3146427 · 3146427
1 parent 19a9ba4
commit 3146427
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.travis.yml b/.travis.yml
@@ -12,6 +12,7 @@ node_js:
  - "7.10"
  - "8.13"
  - "9.11"
+ - "10.13"
 sudo: false
 cache:
  directories:

diff --git a/test/morgan.js b/test/morgan.js
@@ -1036,7 +1036,16 @@ describe('morgan()', function () {
 
  request(server)
  .get('/')
- .expect(102, cb)
+ .expect(102, function (err, res) {
+ if (err && err.code === 'ECONNRESET') {
+ // finishing response with 1xx is invalid http
+ // but node.js server lets the server do this, so
+ // morgan needs to test in this condition even if
+ // the http client doesn't like it
+ err = null
+ }
+ cb(err, res)
+ })
  })
 
  it('should color 2xx green', function (done) {