Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
closes #5014
  • Loading branch information
dougwilson committed Oct 7, 2022
1 parent f56ce73 commit bb7907b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
node-version: "17.9"

- name: Node.js 18.x
node-version: "18.7"
node-version: "18.10"

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ environment:
- nodejs_version: "15.14"
- nodejs_version: "16.17"
- nodejs_version: "17.9"
- nodejs_version: "18.7"
- nodejs_version: "18.10"
cache:
- node_modules
install:
Expand Down
7 changes: 4 additions & 3 deletions test/res.sendFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -1050,12 +1050,13 @@ describe('res', function(){

app.use(function(req, res){
res.sendfile('test/fixtures/user.html', function(err){
assert(!res.headersSent);
assert.strictEqual(req.socket.listeners('error').length, 1) // node's original handler
assert.ok(err)
assert.ok(!res.headersSent)
assert.strictEqual(err.message, 'broken!')
done();
});

req.socket.emit('error', new Error('broken!'));
req.socket.destroy(new Error('broken!'))
});

request(app)
Expand Down

0 comments on commit bb7907b

Please sign in to comment.