feat: restore passOnConnectionError option
#193
+84
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nfriedly @abhijeetviswa Please do review this PR and let me know if I should make any changes. |
nfriedly
requested changes
Sep 13, 2023
There was a problem hiding this comment.
Hey @gamemaker1 , sorry I didn't think of this before you did all this work, but I think the passOnConnectionError option should be in express-rate-limit, rather than here, so that it can be used with any store. I think the store itself should just throw an error.
| throw new TypeError('unexpected reply from redis client') | ||
| } | ||
| if (typeof result !== 'string') | ||
| throw new TypeError('Expected result to be the script SHA') |
There was a problem hiding this comment.
Suggested change
| throw new TypeError('Expected result to be the script SHA') | |
| throw new TypeError(`Expected result of SCRIPT LOAD command to be the script SHA, got ${result}`) |
|
Oh all right that makes sense |
abhijeetviswa
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #190.
It works like a charm with an
ioredisclient. However, thenode-redisclient is a bit stubborn when it comes to reconnecting - it waits for the server to reconnect forever. If you use a customretryStrategythat tells it to stop after x retries, it will stop and not attempt to reconnect, even during the next timeincrementis called. I haven't yet figured out a workaround for that.