Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Update Expokit package #3093

Merged
merged 3 commits into from
Jan 2, 2019
Merged

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Jan 2, 2019

Why

Step of #3030

How

Ran gulp update-exponent-view --abi 32.0.0 in tools and then tried to create Android's shell app. Unfortunately, I've encountered some issues with resource attributes but then I realized we had some duplicated resources in expoview and expo-payments-stripe which might cause these issues, so I just removed them.

Test Plan

Tested NCL shell app with this new expoview.

@tsapeta tsapeta mentioned this pull request Jan 2, 2019
43 tasks
@tsapeta tsapeta force-pushed the @tsapeta/update-expokit-package branch from bf125cc to 00e02ea Compare January 2, 2019 13:52
@tsapeta tsapeta requested a review from sjchmiela January 2, 2019 13:53
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tsapeta tsapeta merged commit d80fa6c into master Jan 2, 2019
@tsapeta tsapeta deleted the @tsapeta/update-expokit-package branch January 2, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants