Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with-router-typescript example #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Josehower
Copy link

Add new with router typescript example based on suggestions #412 (comment)

"metro": "^0.73.7",
"metro-resolver": "^0.73.7"
},
"overrides": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"resolutions" and "overrides" are in the original package.json from with-router as well:

"resolutions": {
"metro": "^0.73.7",
"metro-resolver": "^0.73.7"
},
"overrides": {
"metro": "^0.73.7",
"metro-resolver": "^0.73.7"
},

probably some compatibility thing

@DanHarman
Copy link

Is there any point in this when npx create-expo-app -t offers a typescript with router option, that also has a tab bar and a few example screens?

@mattwoodruff808
Copy link

I will say I would greatly appreciate this PR. I love expo-router, and have been having issues trying to implement TypeScript after spinning up npx create-expo-app@latest --example with-router. This would help me a ton!

@AndresdoSantos
Copy link

I already created the application and installed the TS even before starting to use expo-router, is there a way to type the routes?

@karlhorky
Copy link
Contributor

is there a way to type the routes?

There is a discussion about typed props of a route here (originally an issue, but converted into a discussion):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants