-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2211 - Support for ssl certs config on download command #2212
Conversation
Hi @mn3mos, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agrement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the If you've already included the Contributor Agreement in your pull request above, you can ignore this message. |
Thanks! As @ines noted, this could be related to our recent switch from requests to the core library's urllib, which possibly doesn't look for certificates in extra places. But I think the extra arguments are a good idea. |
Hey this is absolutely awesome, as it's needed most of the time for installing in corporate environments. May anyone suggest how does one update their existing 2.0 installation to this version without breaking things up? And additionally, is there also a way to "import" a module into spacy from a copy downloaded over the Internet outside of the |
Hei, re-opening this because the issues (#2249, #2212, #507) and resources (SO) claim that this should be resolved in v2, but I am still getting the same error when attempting the recommended install:
Setup
venv installed packages (
AttemptsI initially installed the most recent version of spaCy, but for good measure tried to update anyways. I also attempted the suggestion on StackOverflow related to updating the
However, the error persists.
|
However, I figured out that using the direct link works for me:
Any ideas why this one goes through? |
How to add this to requirements.txt? I' like to d/l it automatically for my venv. |
My setup is: python: 3.6.6 I tried running the command: and i get SSL certificate error, able to solve it by running: python3 -m spacy download en_core_web_sm-2.0.0 --direct Please fix this |
I was able to download the models after doing |
Description
This PR adresses issue #2211 by proposing a patch to the command 'download' which allows users to disable the SSL verification of certificates or to customize the Certificate Authentity file which is used for the validation.
Such options are required in some corporate environments which install proxies and mess with the usual certification processes.
This is my first contribution so I need your help, please :)
I am not able yet to tick the boxes in the checklists, can you give me pointers to:
Thanks in advance.
Types of change
I consider this change an enhancement of the CLI tool.
I updated the README too, but not the manual of SpaCy as I don't know how/where to do that.
Checklist