Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map/counter: replace raw array with std::vector and raw pointer with std::unique_ptr #40

Merged
merged 2 commits into from
Mar 13, 2023
Merged

map/counter: replace raw array with std::vector and raw pointer with std::unique_ptr #40

merged 2 commits into from
Mar 13, 2023

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Mar 8, 2023

Replace raw arrays by vector, replace raw pointers by unique_ptr. Also remove unused PreshMapArray

shadeMe
shadeMe reviewed Mar 9, 2023
View reviewed changes
preshed/maps.pyx Show resolved Hide resolved
setup.py Show resolved Hide resolved
@danieldk danieldk merged commit 1486d87 into explosion:master Mar 13, 2023
@danieldk danieldk deleted the feature/safer-data-structures-counter-maps branch March 13, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieldk @shadeMe @svlandeg