Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ClinVar whitelist with optional ClinVar-based scoring #515

Open
julesjacobsen opened this issue Sep 6, 2023 · 2 comments
Open

Comments

@julesjacobsen
Copy link
Contributor

julesjacobsen commented Sep 6, 2023

The ClinVar whitelist option (default = true) will set all P/LP 2*+ variants found in a VCF file to have a score of 1.0.

The issue with this is that, while it works well for pathogenic variants, it is useless for benign variants.

Another issue is that there is no longer a distinction between P and LP. The ACMG guidelines state that there should be a >=0.99 for P and 0.90-0.98 probability of pathogenicity for these categories and a similar range for B/LB.

Converting these probabilities to variant scores which override the default implementation will allow us to keep the boost to the known pathogenic variants and also de-prioritise known benign variants, some of which would otherwise score rather highly.

The implementation issue here is should this be an optional setting which can be set to false for use in internal benchmarks or would this be a case of YAGNI? Also, how would this interact with the whitelist implementation? Would this need to be updated so that the variants on the list should be given a P/LP/LB/B label?

@damiansm
Copy link
Contributor

damiansm commented Sep 7, 2023 via email

@julesjacobsen julesjacobsen changed the title Add optional ClinVar-based scoring Replace ClinVar whitelist with optional ClinVar-based scoring Sep 8, 2023
@julesjacobsen
Copy link
Contributor Author

julesjacobsen commented Sep 8, 2023

Yes, that's the idea. There are these issues to address:

  1. Do we need to define the override_variant_score column? This should be a function of the clinvar_category as defined by the ClinGen SVI group, otherwise users will need to add this themselves and add potentially inconsistent scores.
  2. The current ClinVar whitelist will be replaced with an implementation which automatically filters the ClinVar variant store (see Enable more frequent ClinVar data updates in Exomiser database #501) and populates the whitelist with 2*+ P/LP variants. This whitelist implementation will need to be altered slightly to return an AcmgCategory (P/LP/LB/B) instead of true/false and this added to the VariantEvaluation.

The (now inaccurately named) whitelist can still be toggled on and off using the exomiser.${assembly}.use-clinvar-whitelist option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants