Allow custom section in serverless.yml to be empty

exoego · Apr 9, 2018 · 987a80d · 987a80d
1 parent 4633c11
commit 987a80d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/example/package-lock.json b/example/package-lock.json
diff --git a/example/serverless.yml b/example/serverless.yml
@@ -13,10 +13,6 @@ plugins:
  - serverless-plugin-aws-alerts
  - serverless-plugin-canary-deployments
 
-custom:
- alerts:
- dashboards: false
-
 functions:
  hello:
  handler: handler.hello
@@ -29,7 +25,7 @@ functions:
  - StreamsTestTable
  - StreamArn
  - sns: snsTopic
- - s3: s3SampleBucket
+ - s3: s3samplebucket
  alarms:
  - name: foo
  namespace: 'AWS/Lambda'

diff --git a/serverless-plugin-canary-deployments.js b/serverless-plugin-canary-deployments.js
@@ -183,7 +183,7 @@ class ServerlessCanaryDeployments {
  );
  return getMappingsForFunction(this.compiledTpl.Resources);
  }
- 
+
  getS3EventsFor(functionName) {
  const isEventSourceMapping = _.matchesProperty('Type', 'AWS::S3::Bucket');
  const isMappingForFunction = _.pipe(
@@ -224,7 +224,7 @@ class ServerlessCanaryDeployments {
  }
 
  getDeploymentSettingsFor(serverlessFunction) {
- const globalSettings = _.cloneDeep(this.service.custom.deploymentSettings);
+ const globalSettings = _.path('custom.deploymentSettings', this.service);
  const fnDeploymentSetting = this.service.getFunction(serverlessFunction).deploymentSettings;
  return Object.assign({}, globalSettings, fnDeploymentSetting);
  }