Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Convert example to exemplar #3086

Merged
merged 7 commits into from
Jan 28, 2021
Merged

Convert example to exemplar #3086

merged 7 commits into from
Jan 28, 2021

Conversation

ErikSchierboom
Copy link
Member

A while back there was a discussion on the name of the example files. For Concept Exercises, they are not just an example, but they are the exemplar solution.

Having not yet exploded this repo, we decided to do this renaming now. I've tried to script all the changes, but the word "Example" is used rather a lot :) If there are things obviously wrong or missing, please let me know.

We will be merging this PR before the exploding, so there is relatively little time to review. Sorry about that!

In this PR I'll update the v3-docs documentation.

Copy link
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for Rust. Haven't checked any other languages. Haven't searched for missing cases. We can get all those later.

Copy link
Member

@mpizenberg mpizenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for elm

@mpizenberg
Copy link
Member

Related question, must we use the "examplar" name? In Elm, files must be named like their module declaration, and the module declaration does not use "Examplar" but a name appropriate for the module (same as the one in src/). So for a valid Elm file, it should be named "ModuleName.elm" and not "Examplar.elm". But in the meantime, the name of that file matters less than its content for its role. So my question is can we keep modules names or should we used "Examplar.elm"?

@ErikSchierboom
Copy link
Member Author

Related question, must we use the "examplar" name? In Elm, files must be named like their module declaration, and the module declaration does not use "Examplar" but a name appropriate for the module (same as the one in src/). So for a valid Elm file, it should be named "ModuleName.elm" and not "Examplar.elm". But in the meantime, the name of that file matters less than its content for its role. So my question is can we keep modules names or should we used "Examplar.elm"?

Good question. I think for now we do, but we'll keep your remark in mind when implementing. CC @iHiD

Copy link
Contributor

@mikedamay mikedamay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for C#

@mpizenberg
Copy link
Member

Sorry for the double rename (bad english on my part)

Copy link
Member

@verdammelt verdammelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For common-lisp this appears fine.

@ErikSchierboom ErikSchierboom merged commit c58b8f5 into master Jan 28, 2021
@ErikSchierboom ErikSchierboom deleted the exemple-to-exemplar branch January 28, 2021 13:12
@ErikSchierboom
Copy link
Member Author

Thanks for the reviews!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants