Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[Badges] Add Weekend Exerciser #1752

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Conversation

iHiD
Copy link
Member

@iHiD iHiD commented Jun 25, 2020

Reopened #1744

(cc @ynfle @kotp)

@iHiD iHiD changed the title [Docs] add badges [Badges] add badges Jun 25, 2020
@iHiD iHiD changed the title [Badges] add badges [Badges] Add Weekend Exerciser Jun 25, 2020
@iHiD iHiD self-assigned this Jun 25, 2020
@ynfle
Copy link
Contributor

ynfle commented Jun 25, 2020

Thanks! @iHiD

@ynfle ynfle closed this Jun 25, 2020
@ynfle ynfle force-pushed the docs-add-badge-suggestion branch from 2da3566 to 3ae7c8a Compare June 25, 2020 12:53
@ynfle ynfle reopened this Jun 25, 2020
badges.md Outdated Show resolved Hide resolved
@iHiD
Copy link
Member Author

iHiD commented Jun 25, 2020

So, I'll merge this on two conditions:

  • A new category is created with the heading "May be implemented by the community" with the text "These badges will be implementable by PRs from the community nearer the time of v3 launch. We will announce when the repo is open for those PRs". Pop it under the two existing implement categories.
  • This is moved to that category :)

@ynfle
Copy link
Contributor

ynfle commented Jun 25, 2020

So, I'll merge this on two conditions:

  • A new category is created with the heading "May be implemented by the community" with the text "These badges will be implementable by PRs from the community nearer the time of v3 launch. We will announce when the repo is open for those PRs". Pop it under the two existing implement categories.
  • This is moved to that category :)

Just be clear, which version is being referred to?

@iHiD
Copy link
Member Author

iHiD commented Jun 25, 2020

@ynfle Sorry. I mean the suggestion I put ("Wednesday Warrior"). (As apparently weekends aren't a "thing" as I'd previously thought)

@ErikSchierboom
Copy link
Member

@iHiD Is there anything I can do to help with this PR?

@ErikSchierboom
Copy link
Member

This Friday (Jan 29th 2021), we're going to explode this repo back into the individual track repositories and archive this repo.

As such, this PR needs to be merged by Friday 9am UTC, or it will need to be manually reopened against the track repo.

@iHiD
Copy link
Member Author

iHiD commented Jan 26, 2021

@iHiD Is there anything I can do to help with this PR?

@ErikSchierboom Yes please. Fulfil #1752 (comment) and then merge 💙

@ErikSchierboom ErikSchierboom merged commit 8c4c27a into master Jan 27, 2021
@ErikSchierboom ErikSchierboom deleted the docs-add-badge-suggestion branch January 27, 2021 07:36
@iHiD
Copy link
Member Author

iHiD commented Jan 27, 2021

Thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants