Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated substr by substring #827

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix: replace deprecated substr by substring #827

merged 1 commit into from
Dec 14, 2021

Conversation

pmareke
Copy link
Contributor

@pmareke pmareke commented Nov 2, 2021

Solving this exercise I realised about the deprecation.

@pmareke
fix: replace deprecated substr by substring
74089ae 
Solving this exercise I realised about the deprecation.
@SleeplessByte SleeplessByte added the x:size/small Small amount of work label Dec 14, 2021
@SleeplessByte
Copy link
Member

SleeplessByte commented Dec 14, 2021 •
edited
Loading

Thank you @pmareke ! That was definitely a mistake. Apologies it took so long to get reviewed.

@SleeplessByte SleeplessByte merged commit 27d3865 into exercism:main Dec 14, 2021
@pmareke pmareke deleted the patch-1 branch December 14, 2021 20:23
@pmareke
Copy link
Contributor Author

pmareke commented Dec 14, 2021

Thank you @pedrorolo ! That was definitely a mistake. Apologies it took so long to get reviewed.

Thanks to you! But I'm @pmareke 😆

@SleeplessByte
Copy link
Member

Of jeez. YOU ARE!!!! (fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
x:size/small Small amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmareke @SleeplessByte