Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for more UML arrowheads #7391

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Dec 5, 2023

Currently only in code, not exposed to UI.

image


  • I've also made the arrowheads scale separately, based on the respective arrow section (start/end) when multipoint. But honestly not sure what's better behavior.
  • And reduced size of the arrow arrowhead a bit.

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Dec 6, 2023 2:48pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Dec 6, 2023 2:48pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2023 2:48pm

Copy link

github-actions bot commented Dec 5, 2023

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 72.33% / 70% 45864 / 63401
🟢 Statements 72.33% / 70% 45864 / 63401
🟢 Functions 68.86% / 68% 1453 / 2110
🟢 Branches 80.86% / 70% 5729 / 7085
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/math.ts 71.92% 87.69% 84% 71.92% 72, 88-148, 182-207, 225-230, 234-264, 273-277, 300-302, 310-311, 368-369, 386-387, 450-451, 491-493
src/actions/actionProperties.tsx 94.7% 86.24% 91.37% 94.7% 178-180, 215-216, 249, 392-394, 409-418, 648, 779, 812-813, 861, 893-894, 940, 964, 967, 1095-1127
src/components/App.tsx 69.31% 75.99% 67.97% 69.31% 441-442, 612-613, 629-630, 650-710, 713-719, 722-725, 728-804, 807-826, 834-845, 847-848, 853-854, 858-860, 879-1124, 1184-1185, 1196-1197, 1224-1229, 1239-1283, 1309, 1319, 1326-1329, 1364-1365, 1445-1451, 1456-1470, 1474-1520, 1614-1619, 1622-1652, 1660-1685, 1688-1697, 1700-1813, 1816-1824, 1833-1846, 1849-1875, 1878-1949, 1952-1992, 2038-2039, 2057-2058, 2095-2096, 2100-2101, 2117-2124, 2129-2142, 2148-2149, 2154-2162, 2164-2172, 2184, 2224-2225, 2247-2248, 2255, 2316-2318, 2321-2326, 2331-2332, 2367-2375, 2437-2446, 2469-2471, 2533-2534, 2547-2550, 2553, 2555-2556, 2563-2564, 2570-2571, 2579-2580, 2583-2584, 2587-2590, 2593-2596, 2607-2615, 2620-2621, 2677-2678, 2692-2698, 2704-2712, 2716-2724, 2728-2729, 2732-2769, 2772-2784, 2795-2796, 2807-2808, 2826-2830, 2834-2837, 2844-2846, 2864-2871, 2874, 2876-2881, 2885-2887, 2903-2904, 2906-2915, 2941, 2947, 2986-2987, 3004-3006, 3028-3029, 3035-3038, 3044-3119, 3191-3192, 3197-3200, 3263, 3273-3291, 3294-3300, 3303-3304, 3310-3323, 3409-3410, 3412-3413, 3418-3420, 3445-3459, 3464-3483, 3506-3507, 3540-3542, 3567, 3586-3590, 3601-3602, 3605-3609, 3611-3612, 3614-3617, 3642-3643, 3652-3654, 3656, 3731-3734, 3756-3758, 3768-3769, 3771-3791, 3794-3800, 3817-3820, 3826-3829, 3839-3846, 3850-3851, 3856, 3884-3888, 3892, 3897-3898, 3903-3907, 3939-3940, 3943-3944, 3952-3956, 3960-3970, 3975-4002, 4007-4018, 4077, 4103-4104, 4195, 4372-4373, 4376-4377, 4385, 4397, 4399-4400, 4441-4445, 4496-4502, 4508-4571, 4613, 4662, 4720, 4768-4771, 4774-4780, 4782-4785, 4800-4809, 4812-4813, 4894-4895, 4898, 4900-4901, 4907-4909, 4911, 4920, 4942-4947, 4949-4952, 4956-4957, 4967-5054, 5057-5058, 5072-5073, 5124-5125, 5152-5153, 5183-5209, 5216-5217, 5240-5241, 5261, 5263-5264, 5280-5281, 5287-5288, 5292-5295, 5298-5299, 5314-5341, 5349-5350, 5354-5357, 5359-5363, 5422-5427, 5429-5431, 5447, 5449-5460, 5485-5488, 5547-5548, 5550-5573, 5588-5589, 5701-5730, 5795-5799, 5822-5823, 5843-5844, 5938, 5944-5945, 5968-5987, 6002, 6135, 6157-6198, 6202-6253, 6268, 6277, 6311-6317, 6332-6334, 6476-6480, 6504-6538, 6574, 6576-6583, 6590-6593, 6606, 6629-6630, 6633-6634, 6639-6641, 6644-6645, 6670-6671, 6699-6700, 6782-6783, 6832-6845, 6905-6908, 6934-6935, 6980, 6998-7004, 7011-7014, 7037-7042, 7113-7116, 7122, 7137-7144, 7147-7154, 7210, 7284-7285, 7305-7307, 7310, 7324-7348, 7454-7473, 7483-7522, 7535-7536, 7545-7552, 7566-7578, 7591-7596, 7648-7676, 7678-7679, 7753-7757, 7764, 7766-7802, 7831, 7881, 7900-7902, 7927-7932, 7934-7935, 7940-7971, 7974-7998, 8012-8013, 8019-8028, 8033, 8037-8041, 8050-8051, 8054-8059, 8063-8070, 8100, 8102-8106, 8108-8118, 8134-8136, 8147-8155, 8159-8195, 8198-8269, 8277, 8295-8302, 8304-8320, 8335-8357, 8376-8378, 8423-8424, 8454-8455, 8471, 8548-8551, 8553-8569, 8571-8575, 8587-8588, 8598-8614, 8648-8649, 8653-8665, 8675, 8677-8680, 8682-8683, 8723, 8744-8745, 8771, 8774, 8814, 8828-8835, 8852-8853, 8885-8888, 8977-8984, 9010-9011, 9052-9106, 9150-9151, 9160-9163, 9168-9169, 9190-9192, 9194-9198, 9236
src/components/IconPicker.tsx 24.15% 50% 20% 24.15% 9-145, 183-202
src/components/icons.tsx 94.63% 86.66% 100% 94.63% 1155-1167, 1286-1296, 1301-1312, 1317-1327, 1332-1342, 1347-1360, 1365-1377, 1382-1394
src/element/bounds.ts 81.15% 85.27% 90% 81.15% 187-268, 287-291, 314-315, 447-450, 494, 496, 504, 508, 520-521, 573, 578, 597-599, 608-638, 654-655, 680-691, 747-757, 790-793, 837-838
src/element/linearElementEditor.ts 76.24% 81.67% 89.18% 76.24% 130, 134-183, 198-199, 203-204, 214-215, 217-236, 260-263, 286-294, 329-330, 348-357, 369, 387-395, 472-473, 589-590, 599, 620-621, 627-628, 643-680, 772-773, 777-778, 785-786, 792-794, 796-831, 878, 972-1037, 1051-1058, 1073-1082, 1146-1147, 1186-1187, 1250-1274, 1282-1283, 1382-1414
src/renderer/renderElement.ts 71.65% 68.18% 100% 71.65% 88-90, 149-150, 154-155, 208-209, 256, 304-305, 318-324, 335-338, 352, 368-369, 371-372, 393, 547, 549-561, 614-616, 630-631, 644-654, 693-700, 706-707, 711-772, 777-779, 830-832, 842-843, 859-860, 888-898, 925-928, 939-941, 962-1060, 1063-1153, 1155-1191, 1221, 1223-1224, 1298-1300, 1315, 1317, 1322, 1324, 1350-1352, 1373, 1376, 1403-1404
src/renderer/renderScene.ts 72.64% 81.06% 87.09% 72.64% 108-109, 122-140, 254-255, 291-298, 349-350, 353-354, 367-390, 423-424, 434-435, 457-458, 499-500, 599-607, 624, 710, 733-867, 872-895, 914-915, 956-958, 960-963, 984-985, 995-996, 1003-1045, 1132-1143, 1219, 1264-1275, 1349-1351, 1366-1389, 1398-1443, 1455-1456, 1474-1475, 1483-1497
src/scene/Shape.ts 72.37% 67.08% 85.71% 72.37% 60, 102-107, 113-114, 124-126, 128-133, 135-144, 165-166, 172-190, 193-217, 220-245, 252-254, 390, 403-413, 417-418, 439-444, 460-465
src/scene/ShapeCache.ts 94.04% 100% 83.33% 94.04% 30-34
src/scene/export.ts 87.36% 80.39% 80% 87.36% 70-95, 115-116, 125, 181-182, 206-210, 339-340, 362-372, 458-467
Generated in workflow #1236

@dwelle dwelle requested a review from ad1992 December 5, 2023 13:23
Copy link

github-actions bot commented Dec 5, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 326.32 KB (+0.18% 🔺) 6.6 s (+0.18% 🔺) 640 ms (+10.41% 🔺) 7.2 s
dist/excalidraw-assets/locales 280.73 KB (0%) 5.7 s (0%) 144 ms (+4.49% 🔺) 5.8 s
dist/excalidraw-assets/vendor*.js 826.02 KB (0%) 16.6 s (0%) 1.3 s (+1.13% 🔺) 17.8 s

src/scene/Shape.ts Outdated Show resolved Hide resolved
@ad1992
Copy link
Member

ad1992 commented Dec 5, 2023

@excalibot trigger release

@ad1992
Copy link
Member

ad1992 commented Dec 6, 2023

@excalibot trigger release

@excalibot
Copy link
Member

@ad1992 Preview version has been shipped 🚀
You can use @excalidraw/[email protected] for testing!

Copy link
Member

@ad1992 ad1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants