fix: disable caching bounds for arrow labels #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
size-limit report 📦
|
dwelle
added a commit
that referenced
this pull request
Dec 4, 2023
ad1992
pushed a commit
that referenced
this pull request
Feb 9, 2024
wangshijun
added a commit
to wangshijun/excalidraw-blocklet
that referenced
this pull request
May 22, 2024
patch release * tag 'v0.17.5': v0.17.5 fix: parse embeddable srcdoc urls strictly & escape attribute url html v0.17.4 fix: Gist embed allowing unsafe html (excalidraw#7883) fix: keep customData when converting to ExcalidrawElement (excalidraw#7656) fix: umd build so it can be used in browser (excalidraw#7349) fix: disable caching bounds for arrow labels (excalidraw#7343) fix: bounds cached prematurely resulting in incorrectly rendered labels (excalidraw#7339) docs: upgrade to @excalidraw/[email protected] (excalidraw#7285)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've recently stopped updating arrow labels, we don't invalidate Bounds cache for labels when container is moved. This is causing bugs when checking for visibility and such.
This PR is a hotfix to ignore cache for bound text. Proper fix after proper analysis.