Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image insertion bugs #7278

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix: image insertion bugs #7278

merged 2 commits into from
Nov 13, 2023

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Nov 13, 2023

Fixes:

  • when inserting image using the image file picker, the image-preview cursor was being reset
  • in the same flow, the image was being added to frame that was currently in the center of viewport at time of file picker open. This is incorrect, and it should add the to frame on pointerdown only.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Nov 13, 2023 1:43pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Nov 13, 2023 1:43pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 13, 2023 1:43pm

Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 73.63% / 70% 44767 / 60795
🟢 Statements 73.63% / 70% 44767 / 60795
🟢 Functions 69.85% / 68% 1430 / 2047
🟢 Branches 81.13% / 70% 5631 / 6940
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/cursor.ts 50.47% 54.54% 75% 50.47% 39-76, 83-84, 88, 90-93, 95-99, 103-104
src/components/App.tsx 73.38% 76.26% 73.33% 73.38% 418-419, 602-603, 629-689, 692-698, 701-704, 707-779, 782-801, 809-821, 826-827, 831-833, 852-954, 1014-1015, 1046-1051, 1056-1100, 1105, 1129, 1139, 1146-1149, 1184-1185, 1263-1269, 1361-1366, 1369-1399, 1402-1442, 1488-1489, 1507-1508, 1545-1546, 1550-1551, 1567-1574, 1579-1592, 1598-1599, 1604-1612, 1614-1622, 1634, 1674-1675, 1697-1698, 1705, 1766-1768, 1771-1776, 1781-1782, 1817-1825, 1902-1904, 1965-1966, 1979-1982, 1985, 1987-1988, 1995-1996, 2002-2003, 2011-2012, 2015-2016, 2019-2022, 2025-2028, 2039-2047, 2052-2053, 2109-2110, 2124-2130, 2136-2144, 2148-2156, 2160-2161, 2164-2201, 2204-2216, 2227-2228, 2239-2240, 2258-2262, 2266-2269, 2291-2298, 2301, 2303-2308, 2312-2314, 2330-2331, 2333-2342, 2368, 2374, 2413-2414, 2431-2433, 2455-2456, 2462-2465, 2471-2545, 2617-2618, 2623-2626, 2689, 2699-2717, 2720-2726, 2729-2730, 2736-2749, 2835-2836, 2838-2839, 2844-2846, 2871-2885, 2890-2909, 2932-2933, 2966-2968, 2993, 3012-3016, 3027-3028, 3031-3035, 3037-3038, 3040-3043, 3068-3069, 3078-3080, 3082, 3157-3160, 3182-3184, 3194-3195, 3197-3217, 3220-3226, 3243-3246, 3252-3255, 3265-3272, 3276-3277, 3282, 3301, 3306-3307, 3312-3316, 3348-3349, 3352-3353, 3361-3365, 3369-3379, 3384-3411, 3416-3427, 3486, 3512-3513, 3604, 3781-3782, 3785-3786, 3794, 3806, 3808-3809, 3850-3854, 3905-3911, 3917-3980, 4022, 4071, 4129, 4177-4180, 4183-4189, 4191-4194, 4209-4218, 4221-4222, 4303-4304, 4307, 4309-4310, 4316-4318, 4320, 4329, 4351-4356, 4358-4361, 4365-4366, 4376-4463, 4466-4467, 4481-4482, 4533-4534, 4561-4562, 4592-4618, 4625-4626, 4649-4650, 4670, 4672-4673, 4689-4690, 4696-4697, 4701-4704, 4707-4708, 4723-4750, 4758, 4760, 4762-4766, 4825-4830, 4832-4834, 4850, 4852-4863, 4888-4891, 4950-4951, 4953-4976, 4991-4992, 5104-5133, 5198-5202, 5225-5226, 5246-5247, 5340, 5346-5347, 5370-5389, 5404, 5537, 5560-5611, 5626, 5635, 5669-5675, 5690-5692, 5833-5837, 5861-5889, 5925, 5927-5934, 5941-5944, 5957, 5980-5981, 5984-5985, 5990-5992, 5995-5996, 6021-6022, 6050-6051, 6133-6134, 6183-6196, 6256-6259, 6285-6286, 6331, 6349-6355, 6362-6365, 6388-6393, 6464-6467, 6473, 6488-6495, 6498-6505, 6561, 6635-6636, 6656-6658, 6661, 6675-6699, 6805-6824, 6834-6873, 6886-6887, 6896-6903, 6917-6929, 6942-6947, 6999-7027, 7029-7030, 7104-7108, 7115, 7117-7153, 7182, 7232, 7251-7253, 7278-7283, 7285-7286, 7291-7322, 7325-7349, 7363-7364, 7370-7379, 7384, 7388-7392, 7401-7402, 7405-7410, 7414-7421, 7451, 7453-7457, 7459-7469, 7491-7499, 7503-7539, 7542-7613, 7621, 7639-7646, 7648-7664, 7679-7701, 7720-7722, 7767-7768, 7798-7799, 7815, 7889-7892, 7894-7910, 7912-7916, 7928-7929, 7939-7955, 7989-7990, 7994-7995, 8005, 8007-8010, 8012-8013, 8053, 8074-8075, 8101, 8104, 8144, 8155-8162, 8178-8179, 8211-8214, 8283-8293, 8295-8305, 8336-8343, 8369-8370, 8411-8465, 8509-8510, 8519-8522, 8527-8528, 8549-8551, 8553-8557, 8595
Generated in workflow #987

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 314.15 KB (+0.02% 🔺) 6.3 s (+0.02% 🔺) 611 ms (-8.88% 🔽) 6.9 s
dist/excalidraw-assets/locales 280.73 KB (0%) 5.7 s (0%) 147 ms (-3.94% 🔽) 5.8 s
dist/excalidraw-assets/vendor*.js 826.02 KB (0%) 16.6 s (0%) 1.4 s (-1.67% 🔽) 17.9 s

@dwelle dwelle merged commit 029c3c4 into master Nov 13, 2023
10 checks passed
@dwelle dwelle deleted the dwelle/fix-image-insert branch November 13, 2023 14:35
ad1992 pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants