Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not cloning elements on export polluting Scene mapping #7276

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Nov 12, 2023

No description provided.

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Nov 12, 2023 10:08pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Nov 12, 2023 10:08pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 12, 2023 10:08pm

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 314.28 KB (+0.01% 🔺) 6.3 s (+0.01% 🔺) 122 ms (+20.73% 🔺) 6.5 s
dist/excalidraw-assets/locales 280.73 KB (0%) 5.7 s (0%) 29 ms (+2.38% 🔺) 5.7 s
dist/excalidraw-assets/vendor*.js 826.02 KB (0%) 16.6 s (0%) 248 ms (-0.71% 🔽) 16.8 s

Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 73.63% / 70% 44737 / 60757
🟢 Statements 73.63% / 70% 44737 / 60757
🟢 Functions 69.84% / 68% 1429 / 2046
🟢 Branches 81.16% / 70% 5631 / 6938
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/scene/export.ts 86.96% 85.41% 77.77% 86.96% 65-90, 115, 163-167, 293-294, 316-326, 413-422
Generated in workflow #979

@dwelle dwelle merged commit ae5b9a4 into master Nov 12, 2023
9 checks passed
@dwelle dwelle deleted the dwelle/fix-export-clone branch November 12, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant