Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exportToSvg to honor frameRendering also for name not only for frame itself #7270

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

zsviczian
Copy link
Collaborator

Before this fix, if appState.frameRendering.endabled is set to false the export will omit the frame but include the frame name.

Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Nov 12, 2023 10:29pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Nov 12, 2023 10:29pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2023 10:29pm

@zsviczian zsviczian changed the title fix: exportToSvg to honor frameRendering for name not only for frame itself fix: exportToSvg to honor frameRendering also for name not only for frame itself Nov 11, 2023
Copy link

github-actions bot commented Nov 11, 2023

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 73.64% / 70% 44763 / 60785
🟢 Statements 73.64% / 70% 44763 / 60785
🟢 Functions 69.85% / 68% 1430 / 2047
🟢 Branches 81.15% / 70% 5631 / 6939
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/scene/export.ts 87.33% 83.67% 80% 87.33% 64-89, 114, 167-168, 192-196, 324-325, 347-357, 441-450
Generated in workflow #980

Copy link

github-actions bot commented Nov 11, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 314.34 KB (+0.02% 🔺) 6.3 s (+0.02% 🔺) 591 ms (-11.69% 🔽) 6.9 s
dist/excalidraw-assets/locales 280.73 KB (0%) 5.7 s (0%) 145 ms (-6.7% 🔽) 5.8 s
dist/excalidraw-assets/vendor*.js 826.02 KB (0%) 16.6 s (0%) 1.6 s (+2.68% 🔺) 18.1 s

@dwelle
Copy link
Member

dwelle commented Nov 12, 2023

Good catch. I've modified the code so that we don't overload addFrameLabelsAsTextElements() with conditional behavior, and also used the opportunity to refactor a bit.

@dwelle dwelle enabled auto-merge (squash) November 12, 2023 22:34
@dwelle dwelle merged commit ceb255e into master Nov 12, 2023
9 checks passed
@dwelle dwelle deleted the zsviczian-frame-export-honor-frameRendering branch November 12, 2023 22:34
ad1992 pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants