Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perf issue when ungrouping elements within frame #7265

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Nov 10, 2023

factored out from #7256 and slightly modified

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Nov 10, 2023 2:24pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Nov 10, 2023 2:24pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2023 2:24pm

Copy link

github-actions bot commented Nov 10, 2023

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 73.62% / 70% 44742 / 60773
🟢 Statements 73.62% / 70% 44742 / 60773
🟢 Functions 69.84% / 68% 1429 / 2046
🟢 Branches 81.15% / 70% 5629 / 6936
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/actions/actionGroup.tsx 88.68% 83.78% 83.33% 88.68% 71-73, 91-93, 105-114, 185-186, 193-194, 200-201, 223, 227-234
Generated in workflow #960

Copy link

github-actions bot commented Nov 10, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 314.42 KB (+0.01% 🔺) 6.3 s (+0.01% 🔺) 130 ms (+30.78% 🔺) 6.5 s
dist/excalidraw-assets/locales 280.73 KB (0%) 5.7 s (0%) 20 ms (-13.62% 🔽) 5.7 s
dist/excalidraw-assets/vendor*.js 826.02 KB (0%) 16.6 s (0%) 266 ms (+5.36% 🔺) 16.8 s

@dwelle dwelle merged commit 6363492 into master Nov 10, 2023
9 checks passed
@dwelle dwelle deleted the dwelle/fix-frame-ungrouping-perf branch November 10, 2023 15:13
ad1992 pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant