feat: allow D&D dice app domain for embeds #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dddice.com - rolldicewithfriends
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
dwelle
reviewed
Nov 10, 2023
|
We still haven't figured out how we wanna handle these, but for our D&D friends, let's ship this! That said, I've removed the rolldicewithfriends domain as it's not allowing embedding into 3rd party sites. |
dwelle
approved these changes
Nov 10, 2023
dwelle
changed the title
ad1992
pushed a commit
that referenced
this pull request
Nov 14, 2023
Co-authored-by: David Luzar <[email protected]>
In order to avoid embedding limitations, the easiest way to install "Ignore X-Frame headers" browser extension, then you can embed any web apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
src/element/embeddable.tswith the following ALLOWED_DOMAINS