fix: Fixes the shortcut collision between "toggleHandTool" and "distributeHorizontally" #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the shortcut conflict between "toggleHandTool" and "distributeHorizontally"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Manual test results from Vercel build preview
Seems good to go. |
|
@GabiRepare thanks for the catch. Can you also disable |
dwelle
approved these changes
Nov 10, 2023
ad1992
pushed a commit
that referenced
this pull request
Nov 14, 2023
…ibuteHorizontally" (#7189) Co-authored-by: dwelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#7188
Fix
The shortcut
Hfor Hand tools doesn't filter out theALTkey presses.This PR adds the filter on the Hand tools shorcut.
Possible improvements
actionCanvas.tsxdoesn't exclude theALTand might also need this filterCTRLkey press should probably also be filtered out