Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Transition bug when camera is zoomed #2942

Merged
merged 4 commits into from
Feb 23, 2024
Merged

fix: Transition bug when camera is zoomed #2942

merged 4 commits into from
Feb 23, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Feb 23, 2024 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

  • Fixed issue where start transition did not work properly if deferred
  • Fixed issue where transitions did not cover the whole screen if camera was zoomed

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Feb 23, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 23, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d046887
Status: ✅  Deploy successful!
Preview URL: https://1633f8e4.excaliburjs.pages.dev
Branch Preview URL: https://fix-transition-bug-on-camera.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 907b7e7 into main Feb 23, 2024
4 of 6 checks passed
@eonarheim eonarheim deleted the fix/transition-bug-on-camera-zoom branch February 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eonarheim