Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix expo web #431

Merged
merged 1 commit into from
Jun 18, 2024
Merged

feat: fix expo web #431

merged 1 commit into from
Jun 18, 2024

Conversation

danilaplee
Copy link
Contributor

this fixes the expo web implementation and adds a demo
Screenshot 2024-06-16 at 05 39 56

Copy link

changeset-bot bot commented Jun 16, 2024

⚠️ No Changeset found

Latest commit: 1a76a5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 16, 2024

@danilaplee is attempting to deploy a commit to the evolu Team on Vercel.

A member of the Team first needs to authorize it.

@danilaplee danilaplee force-pushed the fix-expo-web branch 2 times, most recently from 08fe65c to 5eab993 Compare June 16, 2024 03:57
@steida
Copy link
Contributor

steida commented Jun 16, 2024

Wow, thank you! It looks great!

@danilaplee danilaplee force-pushed the fix-expo-web branch 2 times, most recently from c8295d3 to 93dfe10 Compare June 16, 2024 10:55
@danilaplee danilaplee requested a review from steida June 18, 2024 19:37
@danilaplee danilaplee force-pushed the fix-expo-web branch 2 times, most recently from e97fb8f to eb95259 Compare June 18, 2024 20:18
Copy link
Contributor

@steida steida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steida steida merged commit c2637f1 into evoluhq:main Jun 18, 2024
0 of 2 checks passed
@danilaplee
Copy link
Contributor Author

LGTM

invited you to expo organization

@steida
Copy link
Contributor

steida commented Jun 18, 2024

Isn't it possible to run it without email and password?

Screenshot 2024-06-18 at 22 57 32

@danilaplee
Copy link
Contributor Author

Isn't it possible to run it without email and password?

Screenshot 2024-06-18 at 22 57 32

yes it is possible if you connect the organization to the repo we can just automate it from there

@steida
Copy link
Contributor

steida commented Jun 18, 2024

Imagine someone who wants to try Evolu with React Native. It should run with zero-config. Which org?

@danilaplee
Copy link
Contributor Author

Isn't it possible to run it without email and password?
Screenshot 2024-06-18 at 22 57 32

yes it is possible if you connect the organization to the repo we can just automate it from there

actually the project to the repo

@steida
Copy link
Contributor

steida commented Jun 18, 2024

How can I do that, please? :-)

@danilaplee
Copy link
Contributor Author

How can I do that, please? :-)

https://expo.dev/accounts/evolu/projects/evolu/github

@danilaplee
Copy link
Contributor Author

How can I do that, please? :-)

Screenshot 2024-06-18 at 23 02 38

@steida
Copy link
Contributor

steida commented Jun 18, 2024

I have no idea what I should do 😇 I made you an Evolu admin; feel free to set it up. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants