Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: No way to limit total number of filters that can be created #661

Merged
merged 10 commits into from
Oct 13, 2021

Conversation

devashishdxt
Copy link
Contributor

Solution: Add a config parameter to set the total number of filters that can be created

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution: Add a config parameter to set the total number of filters that can be created
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #661 (df72ec5) into main (8e12d94) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

❗ Current head df72ec5 differs from pull request most recent head 4ab57f3. Consider uploading reports for the commit 4ab57f3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   57.03%   57.00%   -0.04%     
==========================================
  Files          63       63              
  Lines        5535     5540       +5     
==========================================
+ Hits         3157     3158       +1     
- Misses       2215     2219       +4     
  Partials      163      163              
Impacted Files Coverage Δ
server/config/config.go 21.60% <20.00%> (-0.07%) ⬇️

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok -- just a small nit on the current locking

rpc/ethereum/namespaces/eth/filters/api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a Changelog entry too?

@devashishdxt
Copy link
Contributor Author

LGTM, can you add a Changelog entry too?

Done

CHANGELOG.md Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) October 13, 2021 09:02
@fedekunze
Copy link
Contributor

@devashishdxt can you fix the linter issues?

auto-merge was automatically disabled October 13, 2021 09:54

Head branch was pushed to by a user without write access

@devashishdxt
Copy link
Contributor Author

@devashishdxt can you fix the linter issues?

Done

@fedekunze fedekunze enabled auto-merge (squash) October 13, 2021 11:00
@fedekunze fedekunze merged commit c7a2fb9 into evmos:main Oct 13, 2021
@devashishdxt devashishdxt deleted the filter-cap branch October 15, 2021 02:03
thomas-nguy pushed a commit to crypto-org-chain/ethermint that referenced this pull request Oct 26, 2021
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants