-
Notifications
You must be signed in to change notification settings - Fork 561
Problem: No way to limit total number of filters that can be created #661
Conversation
Solution: Add a config parameter to set the total number of filters that can be created
Codecov Report
@@ Coverage Diff @@
## main #661 +/- ##
==========================================
- Coverage 57.03% 57.00% -0.04%
==========================================
Files 63 63
Lines 5535 5540 +5
==========================================
+ Hits 3157 3158 +1
- Misses 2215 2219 +4
Partials 163 163
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok -- just a small nit on the current locking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add a Changelog entry too?
Done |
@devashishdxt can you fix the linter issues? |
Head branch was pushed to by a user without write access
Done |
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Solution: Add a config parameter to set the total number of filters that can be created
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)