Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: align filter rule for debug trace block #1688

Merged
merged 11 commits into from
Mar 23, 2023
Merged

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Feb 28, 2023

Closes: #1691

Description

Currently debug_traceBlockByNumber returns transactions include failed one like insufficient balance


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe marked this pull request as ready for review February 28, 2023 05:13
@mmsqe mmsqe requested a review from a team as a code owner February 28, 2023 05:13
@mmsqe mmsqe requested review from 0a1c and GAtom22 and removed request for a team February 28, 2023 05:13
@mmsqe mmsqe changed the title fix: align filter rule for debug_traceBlockByNumber fix: align filter rule for debug trace block Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1688 (bc4327b) into main (95c4c15) will decrease coverage by 0.05%.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   68.20%   68.15%   -0.05%     
==========================================
  Files         112      112              
  Lines       10167    10175       +8     
==========================================
+ Hits         6934     6935       +1     
- Misses       2827     2832       +5     
- Partials      406      408       +2     
Impacted Files Coverage Δ
rpc/types/utils.go 0.00% <ø> (ø)
rpc/backend/tracing.go 60.46% <12.50%> (-3.18%) ⬇️

@facs95 facs95 merged commit f594627 into evmos:main Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: debug_traceBlock family should not return Tendermint failed ETH Tx
2 participants