Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: revert changes from TypedEvents #1600

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Conversation

Vvaradinov
Copy link
Contributor

Closes: #XXX

Description

This PR reverts the changes made in #1544 as they are breaking the RPCs. Further changes will be made and tested in #1592 but for the time being to unblock immediate work this is being reverted.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@Vvaradinov Vvaradinov requested a review from a team as a code owner January 11, 2023 12:52
@Vvaradinov Vvaradinov requested review from hanchon and adisaran64 and removed request for a team January 11, 2023 12:52
@github-actions github-actions bot added C:Proto protobuf files (*.pb.go) Type: Build codebase build process Type: Tests issues and PR related to tests labels Jan 11, 2023
@github-actions github-actions bot added the Type: CI continuous integration label Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1600 (d8e134f) into main (9003b6f) will increase coverage by 0.11%.
The diff coverage is 97.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
+ Coverage   68.19%   68.31%   +0.11%     
==========================================
  Files         110      110              
  Lines       10087    10087              
==========================================
+ Hits         6879     6891      +12     
+ Misses       2801     2793       -8     
+ Partials      407      403       -4     
Impacted Files Coverage Δ
x/evm/keeper/msg_server.go 90.90% <96.15%> (+3.54%) ⬆️
x/evm/keeper/keeper.go 87.13% <100.00%> (+1.58%) ⬆️
x/feemarket/keeper/abci.go 93.02% <100.00%> (+13.02%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although there's no need to remove the proto files

@github-actions github-actions bot removed the C:Proto protobuf files (*.pb.go) label Jan 11, 2023
@Vvaradinov Vvaradinov merged commit 20c82d0 into main Jan 11, 2023
@Vvaradinov Vvaradinov deleted the Vvaradinov/revert-typed-events branch January 11, 2023 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Build codebase build process Type: CI continuous integration Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants